Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10977083: Update the way that pub determines DART_SDK on macos/linux. (Closed)

Created:
8 years, 2 months ago by dgrove
Modified:
8 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update the way that pub determines DART_SDK on macos/linux. Committed: https://code.google.com/p/dart/source/detail?r=13037

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M utils/pub/sdk/pub View 1 chunk +8 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
dgrove
8 years, 2 months ago (2012-09-28 17:34:56 UTC) #1
Bob Nystrom
Assuming my question has an OK answer, LGTM. https://codereview.chromium.org/10977083/diff/1/utils/pub/sdk/pub File utils/pub/sdk/pub (right): https://codereview.chromium.org/10977083/diff/1/utils/pub/sdk/pub#newcode1 utils/pub/sdk/pub:1: #!/bin/bash ...
8 years, 2 months ago (2012-09-28 17:38:04 UTC) #2
dgrove
https://codereview.chromium.org/10977083/diff/1/utils/pub/sdk/pub File utils/pub/sdk/pub (right): https://codereview.chromium.org/10977083/diff/1/utils/pub/sdk/pub#newcode1 utils/pub/sdk/pub:1: #!/bin/bash On 2012/09/28 17:38:04, Bob Nystrom wrote: > I'm ...
8 years, 2 months ago (2012-09-28 17:49:29 UTC) #3
Bob Nystrom
8 years, 2 months ago (2012-09-28 18:10:51 UTC) #4
SGTM. LGTM!

Powered by Google App Engine
This is Rietveld 408576698