Issue 10977033: Cleanup the core/object.dart file.

Issue 10977033: Cleanup the core/object.dart file. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 2 months ago

Reviewers:
ngeoffray, Ivan Posva

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup the core/object.dart file. Move "Type" and "identical" into separate files. Make runtimeType a getter. Committed: https://code.google.com/p/dart/source/detail?r=12899

Patch Set 1 #

Total comments: 3

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -23 lines)			Patch
M	lib/compiler/implementation/enqueue.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/lib/core.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/core_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/interceptors.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/core/core.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	lib/core/corelib_sources.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	lib/core/identical.dart	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	lib/core/object.dart	View	1 chunk	+2 lines, -11 lines	2 comments	Download
A +	lib/core/type.dart	View	1 chunk	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/10977033/diff/1/lib/core/type.dart File lib/core/type.dart (left): https://codereview.chromium.org/10977033/diff/1/lib/core/type.dart#oldcode5 lib/core/type.dart:5: class _DOMURLFactoryProvider { Funky :-)

8 years, 2 months ago (2012-09-26 10:37:21 UTC) #2

Ivan Posva

DBC -ip https://codereview.chromium.org/10977033/diff/1/lib/core/object.dart File lib/core/object.dart (right): https://codereview.chromium.org/10977033/diff/1/lib/core/object.dart#newcode63 lib/core/object.dart:63: external Type get runtimeType; Any particular reason ...

8 years, 2 months ago (2012-09-27 00:02:14 UTC) #3

ngeoffray

8 years, 2 months ago (2012-09-27 08:29:35 UTC) #4

https://codereview.chromium.org/10977033/diff/1/lib/core/object.dart
File lib/core/object.dart (right):

https://codereview.chromium.org/10977033/diff/1/lib/core/object.dart#newcode63
lib/core/object.dart:63: external Type get runtimeType;
On 2012/09/27 00:02:14, Ivan Posva wrote:
> Any particular reason why you did not have to update the corresponding
language
> tests? As far as I understand they should now be failing.

Right, thanks for noticing Ivan. The test was actually not being run because it
didn't have the _test suffix. Fixed in:
https://codereview.chromium.org/10996043/

Expand Messages | Collapse Messages