Issue 10977027: Update all occurrences of raw strings.

Issue 10977027: Update all occurrences of raw strings. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, kasperl, hausner

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update all occurrences of raw strings. R=hausner@google.com,kasperl@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12893

Patch Set 2 : Fix VM scanner test. #

Patch Set 3 : Don't disable just yet. #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -50 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/regexp.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/process_impl.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/scanner_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/backend_htype_list_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/builtin_equals_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/call_site_type_inferer_test.dart	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/compiler/dart2js/gvn_dynamic_field_get_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/language/string_escapes_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/path_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -1 line	1 comment	Download
M	utils/template/uitest.dart	View		12 chunks	+12 lines, -12 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM! https://codereview.chromium.org/10977027/diff/5001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/10977027/diff/5001/tools/testing/dart/test_suite.dart#newcode690 tools/testing/dart/test_suite.dart:690: args= args.map((arg)=>arg.replaceAll(r"$dartDir", dartDir.toString())); While you are here: space ...

8 years, 2 months ago (2012-09-26 06:18:43 UTC) #2

lgtm

Expand Messages | Collapse Messages