Issue 10977020: In strict comarison use constants instead of registers if possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10977020: In strict comarison use constants instead of registers if possible. (Closed)

Created:
8 years, 2 months ago by srdjan

Modified:
8 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

In strict comarison use constants instead of registers if possible. Committed: https://code.google.com/p/dart/source/detail?r=12879

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -11 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+41 lines, -11 lines	0 comments	Download
	A	tests/language/strict_equal_test.dart	View		1 chunk	+77 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/10977020/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/10977020/diff/1/runtime/vm/intermediate_language.cc#newcode1582 runtime/vm/intermediate_language.cc:1582: __ LoadObject(locs()->out().reg(), result ? compiler->bool_true() : extra space ...

8 years, 2 months ago (2012-09-25 20:21:04 UTC) #2

srdjan

8 years, 2 months ago (2012-09-25 20:26:04 UTC) #3

https://codereview.chromium.org/10977020/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/10977020/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1582: __ LoadObject(locs()->out().reg(), 
result ? compiler->bool_true() :
On 2012/09/25 20:21:04, regis wrote:
> extra space before result.

Done.

Expand Messages | Collapse Messages

Issue 10977020: In strict comarison use constants instead of registers if possible. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages