Issue 10974005: Disable loop invariant code motion on deoptimized functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10974005: Disable loop invariant code motion on deoptimized functions. (Closed)

Created:
8 years, 3 months ago by zerny-google

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable loop invariant code motion on deoptimized functions. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=12771

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/vm/compiler.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years, 3 months ago (2012-09-24 11:08:50 UTC) #2

LGTM with one comment.

https://codereview.chromium.org/10974005/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/10974005/diff/1/runtime/vm/compiler.cc#newcod...
runtime/vm/compiler.cc:217: parsed_function.function().deoptimization_counter()
== 0) {
Since there could be other deoptimizations than those caused by code motion, I'd
rather write

parsed_function.function().deoptimization_counter() ==
FLAG_deoptimization_counter_threshold - 1 

to only disable it on the last re-compilation.

Expand Messages | Collapse Messages