Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1097383002: Don't declare the HTML output of the PubServeTransformer. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't declare the HTML output of the PubServeTransformer. This output won't always be generated, and if we always declare it "pub serve" will produce unsightly error messages when it would conflict if generated. See #84 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/a5c9349edd63f54b392ef30539e530b007773cc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M lib/pub_serve.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-04-21 19:43:44 UTC) #1
kevmoo
lgtm
5 years, 8 months ago (2015-04-21 19:46:13 UTC) #2
nweiz
5 years, 8 months ago (2015-04-21 19:47:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5c9349edd63f54b392ef30539e530b007773cc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698