Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 1097353003: Revert "Fix warnings and hints in the SDK" (Closed)

Created:
5 years, 8 months ago by Søren Gjesse
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Fix warnings and hints in the SDK" This reverts r45331. TBR=lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M sdk/lib/async/stream_impl.dart View 1 chunk +18 lines, -19 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 8 months ago (2015-04-22 11:08:25 UTC) #1
Søren Gjesse
Committed patchset #1 (id:1) manually as 45338 (presubmit successful).
5 years, 8 months ago (2015-04-22 11:08:49 UTC) #2
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-04 09:15:45 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698