Create a wrapper around test.dart for running co19 tests.

Create a wrapper around test.dart for running co19 tests.

Committed: https://code.google.com/p/dart/source/detail?r=12775

[kasperl, 2012-09-24 12:33:32]

LGTM!

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
File dart/tools/testing/dart/co19_test.dart (right):

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:5: #library("co19_test");
Where is this library used from? It looks like it's probably designed to be used
standalone as a separate script. Maybe add a comment to explain how this is
usually run and why this is more convenient than using test.py with a co19
argument?

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:28: new
Path.fromNative(scriptFile.fullPathSync())
4 space indent?

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:41: if (configurations == null ||
configurations.length == 0) return;
.length == 0 -> isEmpty()?

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:43: var firstConf = configurations[0];
firstConf -> firstConfiguration?

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:57: var conf =
configurationIterator.next();
conf -> configuration?

[ahe, 2012-09-24 12:51:57]

Thank you, Kasper!

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
File dart/tools/testing/dart/co19_test.dart (right):

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:5: #library("co19_test");
On 2012/09/24 12:33:32, kasperl wrote:
> Where is this library used from? It looks like it's probably designed to be
used
> standalone as a separate script. Maybe add a comment to explain how this is
> usually run and why this is more convenient than using test.py with a co19
> argument?

Done.

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:28: new
Path.fromNative(scriptFile.fullPathSync())
On 2012/09/24 12:33:32, kasperl wrote:
> 4 space indent?

Done.

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:41: if (configurations == null ||
configurations.length == 0) return;
On 2012/09/24 12:33:32, kasperl wrote:
> .length == 0 -> isEmpty()?

Done.

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:43: var firstConf = configurations[0];
On 2012/09/24 12:33:32, kasperl wrote:
> firstConf -> firstConfiguration?

Done.

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:57: var conf =
configurationIterator.next();
On 2012/09/24 12:33:32, kasperl wrote:
> conf -> configuration?

Done.

[William Hesse, 2012-09-25 09:05:05]

Oops - forgot to hit send on my comment.

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
File dart/tools/testing/dart/co19_test.dart (right):

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:14: 
Please document this script: "This is a script for running many test
configurations on the co19 test scripts, collectiong their output into one
report.  It is used when updating the version of co19 tests in the Dart
repository.
It needs to use the testing library directly, rather than just calling multiple
test.dart instances, so the failures can all be reported in one place."

I assume that is the reason it can't be just multiple runs of test.py.

[ahe, 2012-09-25 09:17:03]

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
File dart/tools/testing/dart/co19_test.dart (right):

https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
dart/tools/testing/dart/co19_test.dart:14: 
On 2012/09/25 09:05:05, William Hesse wrote:
> Please document this script: "This is a script for running many test
> configurations on the co19 test scripts, collectiong their output into one
> report.  It is used when updating the version of co19 tests in the Dart
> repository.
> It needs to use the testing library directly, rather than just calling
multiple
> test.dart instances, so the failures can all be reported in one place."
> 
> I assume that is the reason it can't be just multiple runs of test.py.

Could you rebase your comment to the comment I added in response to Kasper's
suggestion?

[William Hesse, 2012-09-25 12:20:12]

The comment you have added is fine.

On 2012/09/25 09:17:03, ahe wrote:
>
https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
> File dart/tools/testing/dart/co19_test.dart (right):
> 
>
https://codereview.chromium.org/10973009/diff/1/dart/tools/testing/dart/co19_...
> dart/tools/testing/dart/co19_test.dart:14: 
> On 2012/09/25 09:05:05, William Hesse wrote:
> > Please document this script: "This is a script for running many test
> > configurations on the co19 test scripts, collectiong their output into one
> > report.  It is used when updating the version of co19 tests in the Dart
> > repository.
> > It needs to use the testing library directly, rather than just calling
> multiple
> > test.dart instances, so the failures can all be reported in one place."
> > 
> > I assume that is the reason it can't be just multiple runs of test.py.
> 
> Could you rebase your comment to the comment I added in response to Kasper's
> suggestion?