Issue 10972007: Update co19 to r343.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10972007: Update co19 to r343. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update co19 to r343. Committed: https://code.google.com/p/dart/source/detail?r=12774

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -1087 lines)			Patch
M	dart/tests/co19/co19-compiler.status	View	13 chunks	+41 lines, -263 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	19 chunks	+24 lines, -410 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View	16 chunks	+35 lines, -412 lines	0 comments	Download
M	dart/tools/testing/dart/scrub_status_file.dart	View	1 chunk	+2 lines, -1 line	2 comments	Download
M	deps/all.deps/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/10972007/diff/1/dart/tools/testing/dart/scrub_status_file.dart File dart/tools/testing/dart/scrub_status_file.dart (right): https://codereview.chromium.org/10972007/diff/1/dart/tools/testing/dart/scrub_status_file.dart#newcode20 dart/tools/testing/dart/scrub_status_file.dart:20: // TODO(ahe): Enable this when dart2dart stops using ...

8 years, 2 months ago (2012-09-24 11:56:32 UTC) #3

ahe

8 years, 2 months ago (2012-09-24 12:53:39 UTC) #4

Thank you!

https://codereview.chromium.org/10972007/diff/1/dart/tools/testing/dart/scrub...
File dart/tools/testing/dart/scrub_status_file.dart (right):

https://codereview.chromium.org/10972007/diff/1/dart/tools/testing/dart/scrub...
dart/tools/testing/dart/scrub_status_file.dart:20: // TODO(ahe): Enable this
when dart2dart stops using *.
On 2012/09/24 11:56:32, Lasse Reichstein Nielsen wrote:
> Stops using multiplication?

See http://dartbug.com/5401

Expand Messages | Collapse Messages