Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1097083002: add optional importUri to completion suggestion (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add optional importUri to completion suggestion BUG=dartbug.com/23175 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45288

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : bump spec version #

Total comments: 1

Patch Set 4 : merge #

Messages

Total messages: 7 (1 generated)
danrubel
5 years, 8 months ago (2015-04-20 14:13:05 UTC) #2
Brian Wilkerson
LGTM except that we need to bump the version number of the specification
5 years, 8 months ago (2015-04-20 15:00:23 UTC) #3
danrubel
On 2015/04/20 15:00:23, Brian Wilkerson wrote: > LGTM except that we need to bump the ...
5 years, 8 months ago (2015-04-20 15:20:48 UTC) #4
Brian Wilkerson
https://codereview.chromium.org/1097083002/diff/40001/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/1097083002/diff/40001/pkg/analysis_server/tool/spec/spec_input.html#newcode8 pkg/analysis_server/tool/spec/spec_input.html:8: <h1 style="color:#999999">Version <version>1.6.1</version></h1> I don't know whether that's right ...
5 years, 8 months ago (2015-04-20 15:27:10 UTC) #5
danrubel
On 2015/04/20 15:27:10, Brian Wilkerson wrote: > https://codereview.chromium.org/1097083002/diff/40001/pkg/analysis_server/tool/spec/spec_input.html > File pkg/analysis_server/tool/spec/spec_input.html (right): > > https://codereview.chromium.org/1097083002/diff/40001/pkg/analysis_server/tool/spec/spec_input.html#newcode8 ...
5 years, 8 months ago (2015-04-20 15:31:39 UTC) #6
danrubel
5 years, 8 months ago (2015-04-20 15:33:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 45288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698