Issue 10970070: Fix bad diagnostic positions when inlining super constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10970070: Fix bad diagnostic positions when inlining super constructors. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bad diagnostic positions when inlining super constructors. Committed: https://code.google.com/p/dart/source/detail?r=12787

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -39 lines)			Patch
M	dart/lib/compiler/implementation/ssa/builder.dart	View	1 chunk	+35 lines, -33 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/dart2js_extra.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart	View	1 chunk	+53 lines, -0 lines	2 comments	Download
A +	dart/tests/compiler/dart2js_extra/inline_position_crash_test.dart	View	1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

https://codereview.chromium.org/10970070/diff/1/dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart File dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart (right): https://codereview.chromium.org/10970070/diff/1/dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart#newcode6 dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart:6: * Long comment to make positions in this file ...

8 years, 3 months ago (2012-09-24 16:39:48 UTC) #3

ahe

8 years, 3 months ago (2012-09-24 17:09:22 UTC) #4

https://codereview.chromium.org/10970070/diff/1/dart/tests/compiler/dart2js_e...
File dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart
(right):

https://codereview.chromium.org/10970070/diff/1/dart/tests/compiler/dart2js_e...
dart/tests/compiler/dart2js_extra/inline_position_crash_source.dart:6: * Long
comment to make positions in this file exceed the those in the other.
On 2012/09/24 16:39:48, ngeoffray wrote:
> the those -> those

In CL: https://codereview.chromium.org/10967074

Expand Messages | Collapse Messages