Issue 10970038: Convert raw strings in compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10970038: Convert raw strings in compiler (Closed)

Created:
8 years, 3 months ago by danrubel

Modified:
8 years, 3 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Convert raw strings in compiler Committed: https://code.google.com/p/dart/source/detail?r=12783

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -265 lines)			Patch
M	lib/compiler/implementation/dart2js.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/backend.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/renamer.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/js_backend/constant_emitter.dart	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/emitter.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/namer.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/lib/interceptors.dart	View	1	27 chunks	+51 lines, -51 lines	0 comments	Download
M	lib/compiler/implementation/lib/isolate_patch.dart	View	1	7 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/lib/js_helper.dart	View	1	38 chunks	+153 lines, -153 lines	0 comments	Download
M	lib/compiler/implementation/lib/math_patch.dart	View	1	1 chunk	+11 lines, -11 lines	0 comments	Download
M	lib/compiler/implementation/lib/regexp_helper.dart	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/compiler/implementation/lib/string_helper.dart	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/js_names.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 3 months ago (2012-09-24 07:42:28 UTC) #2

LGTM, thank you for doing this.

Nicolas: don't bother reviewing this. It is boring ;-)

Expand Messages | Collapse Messages