Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 10970009: Add list.removeAt method. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add list.removeAt method. Committed: https://code.google.com/p/dart/source/detail?r=12627

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated doc-comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M lib/compiler/implementation/lib/interceptors.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/core/list.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/lib/array.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/corelib/list_removeat_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-20 09:11:38 UTC) #1
ngeoffray
https://codereview.chromium.org/10970009/diff/1/lib/core/list.dart File lib/core/list.dart (right): https://codereview.chromium.org/10970009/diff/1/lib/core/list.dart#newcode99 lib/core/list.dart:99: * Removes the element at position[index] from the list. ...
8 years, 3 months ago (2012-09-20 09:16:24 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/10970009/diff/1/runtime/lib/array.dart File runtime/lib/array.dart (right): https://codereview.chromium.org/10970009/diff/1/runtime/lib/array.dart#newcode171 runtime/lib/array.dart:171: "Cannot modify an immitable array"); immitable => immutable
8 years, 3 months ago (2012-09-20 09:22:50 UTC) #3
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-20 10:50:29 UTC) #4
https://codereview.chromium.org/10970009/diff/1/lib/core/list.dart
File lib/core/list.dart (right):

https://codereview.chromium.org/10970009/diff/1/lib/core/list.dart#newcode99
lib/core/list.dart:99: * Removes the element at position[index] from the list.
Performance through inconvenience :)
I don't think it's going to work in the long run. I'd rather provide the methods
that people want to call than make it hard to get the job done (even if it's
done slowly).

https://codereview.chromium.org/10970009/diff/1/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/10970009/diff/1/runtime/lib/array.dart#newcod...
runtime/lib/array.dart:171: "Cannot modify an immitable array");
On 2012/09/20 09:22:50, Johnni Winther wrote:
> immitable => immutable

Done.

Powered by Google App Engine
This is Rietveld 408576698