Issue 10970006: Correctly handle const constructors with type parameters.

Issue 10970006: Correctly handle const constructors with type parameters. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
ahe, Anton Muhin

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Correctly handle const constructors with type parameters. Committed: https://code.google.com/p/dart/source/detail?r=12697

Patch Set 6 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -18 lines)			Patch
M	lib/compiler/implementation/lib/math_patch.dart	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1 2 3 4 5	3 chunks	+8 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1 2 3 4	1 chunk	+2 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3 4 5	2 chunks	+0 lines, -3 lines	0 comments	Download
A	tests/language/const_constructor_test.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2 3 4 5	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

Nicolas, thanks a lot for a quick fix! You should probably also update co19 dart2dart ...

8 years, 3 months ago (2012-09-20 07:05:41 UTC) #2

ahe

LGTM! http://codereview.chromium.org/10970006/diff/1/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): http://codereview.chromium.org/10970006/diff/1/lib/compiler/implementation/scanner/listener.dart#newcode1374 lib/compiler/implementation/scanner/listener.dart:1374: void handleConstExpression(Token token, bool named) { Couldn't you ...

8 years, 3 months ago (2012-09-20 09:04:30 UTC) #3

ngeoffray

Thanks Peter and Anton http://codereview.chromium.org/10970006/diff/1/lib/compiler/implementation/scanner/listener.dart File lib/compiler/implementation/scanner/listener.dart (right): http://codereview.chromium.org/10970006/diff/1/lib/compiler/implementation/scanner/listener.dart#newcode1374 lib/compiler/implementation/scanner/listener.dart:1374: void handleConstExpression(Token token, bool named) ...

8 years, 3 months ago (2012-09-20 12:10:04 UTC) #4

ngeoffray

PTAL, I realized we were not making it a compile time error when calling a ...

8 years, 3 months ago (2012-09-20 12:52:48 UTC) #5

ngeoffray

On 2012/09/20 12:52:48, ngeoffray wrote: > PTAL, I realized we were not making it a ...

8 years, 3 months ago (2012-09-21 11:50:03 UTC) #6

ahe

LGTM! http://codereview.chromium.org/10970006/diff/9001/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): http://codereview.chromium.org/10970006/diff/9001/lib/compiler/implementation/resolver.dart#newcode2618 lib/compiler/implementation/resolver.dart:2618: } else if (inConstContext && This isn't right. ...

8 years, 3 months ago (2012-09-21 11:52:21 UTC) #7

Anton Muhin

http://codereview.chromium.org/10970006/diff/9001/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): http://codereview.chromium.org/10970006/diff/9001/tests/co19/co19-dart2dart.status#newcode17 tests/co19/co19-dart2dart.status:17: Language/07_Classes/6_Constructors_A03_t03: Fail # Using default constructor On 2012/09/21 11:52:21, ...

8 years, 3 months ago (2012-09-21 12:07:14 UTC) #8

ngeoffray

8 years, 3 months ago (2012-09-21 12:27:29 UTC) #9

Thanks!

http://codereview.chromium.org/10970006/diff/9001/lib/compiler/implementation...
File lib/compiler/implementation/resolver.dart (right):

http://codereview.chromium.org/10970006/diff/9001/lib/compiler/implementation...
lib/compiler/implementation/resolver.dart:2618: } else if (inConstContext &&
On 2012/09/21 11:52:21, ahe wrote:
> This isn't right.

Added a couple of TODOs.

http://codereview.chromium.org/10970006/diff/9001/tests/co19/co19-dart2dart.s...
File tests/co19/co19-dart2dart.status (right):

http://codereview.chromium.org/10970006/diff/9001/tests/co19/co19-dart2dart.s...
tests/co19/co19-dart2dart.status:17: Language/07_Classes/6_Constructors_A03_t03:
Fail # Using default constructor
On 2012/09/21 12:07:14, Anton Muhin wrote:
> On 2012/09/21 11:52:21, ahe wrote:
> > I don't know what this means. Perhaps just add a TODO for Anton to triage.
> 
> Nicolas, plain TRIAGE or BUG will do it.  Or expand the comment, please

Bug filed: http://code.google.com/p/dart/issues/detail?id=5349

Expand Messages | Collapse Messages