Issue 10969067: Attach positions to methods with interceptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10969067: Attach positions to methods with interceptors. (Closed)

Created:
8 years, 2 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
ahe, podivilov1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attach positions to methods with interceptors. R=ahe@google.com BUG=5331 Committed: https://code.google.com/p/dart/source/detail?r=12782

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	lib/compiler/implementation/ssa/builder.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	tests/compiler/dart2js/source_mapping_test.dart	View		2 chunks	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/10969067/diff/1/tests/compiler/dart2js/source_mapping_test.dart File tests/compiler/dart2js/source_mapping_test.dart (right): https://codereview.chromium.org/10969067/diff/1/tests/compiler/dart2js/source_mapping_test.dart#newcode92 tests/compiler/dart2js/source_mapping_test.dart:92: String INTERCEPTOR_TEST = '''void main() { var l ...

8 years, 2 months ago (2012-09-24 12:56:21 UTC) #2

podivilov1

8 years, 2 months ago (2012-09-24 15:04:49 UTC) #3

https://codereview.chromium.org/10969067/diff/1/tests/compiler/dart2js/source...
File tests/compiler/dart2js/source_mapping_test.dart (right):

https://codereview.chromium.org/10969067/diff/1/tests/compiler/dart2js/source...
tests/compiler/dart2js/source_mapping_test.dart:92: String INTERCEPTOR_TEST =
'''void main() { var l = []; @l.add(0); print(l); }''';
On 2012/09/24 12:56:21, ahe wrote:
> Long line.

Done.

Expand Messages | Collapse Messages