Issue 10969024: Issue 5163. Constructor/member name conflict should be error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10969024: Issue 5163. Constructor/member name conflict should be error (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5163. Constructor/member name conflict should be error http://code.google.com/p/dart/issues/detail?id=5163 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12660

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	2 chunks	+9 lines, -3 lines	1 comment	Download
M	tests/utils/utils.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 3 months ago (2012-09-20 21:26:30 UTC) #2

LGTM

https://codereview.chromium.org/10969024/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/10969024/diff/1/tests/language/language.statu...
tests/language/language.status:108: #bad_constructor_test/05: Fail # Constructor
name clashes with other member
Did you intend to remove this line?

Expand Messages | Collapse Messages