Issue 10968058: Support constant folding of instructions with constant smi values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10968058: Support constant folding of instructions with constant smi values. (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support constant folding of instructions with constant smi values. In sparse conditional constant propagation, replace instructions with constant smi values with their constant value. Extend the analysis to understant shift and bitwise binary operations. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12778

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+217 lines, -189 lines)			Patch
M	runtime/lib/integers.cc	View	11 chunks	+13 lines, -125 lines	0 comments	Download
M	runtime/platform/utils.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/platform/utils.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	15 chunks	+83 lines, -58 lines	2 comments	Download
M	runtime/vm/object.h	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+103 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://codereview.chromium.org/10968058/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/10968058/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode2931 runtime/vm/flow_graph_optimizer.cc:2931: // objects into the heap's old generation. Maybe ...

8 years, 3 months ago (2012-09-24 11:36:17 UTC) #2

Kevin Millikin (Google)

8 years, 3 months ago (2012-09-24 12:23:46 UTC) #3

https://codereview.chromium.org/10968058/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/10968058/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2931: // objects into the heap's old
generation.
On 2012/09/24 11:36:17, Florian Schneider wrote:
> Maybe add a TODO to extend the analysis for bool-valued constants or other
known
> old-space objects like null.

Done.

Expand Messages | Collapse Messages