Issue 10968040: Eliminate some of the flakiness in testing:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10968040: Eliminate some of the flakiness in testing: (Closed)

Created:
8 years, 3 months ago by gram

Modified:
8 years, 3 months ago

Reviewers:
ahe, Emily Fortuna, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate some of the flakiness in testing: - errors in test_controller.js get posted to the Dart configs - Dart configs will receive these and set uncaughtError - Selenium driver will output the full HTML body, not just up to the first script tag (else the errors above could be lost). Committed: https://code.google.com/p/dart/source/detail?r=12735

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -10 lines)			Patch
M	pkg/unittest/html_config.dart	View	2 chunks	+20 lines, -4 lines	0 comments	Download
M	pkg/unittest/html_enhanced_config.dart	View	2 chunks	+14 lines, -4 lines	0 comments	Download
M	pkg/unittest/test_controller.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/unittest/unittest.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/testing/run_selenium.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages