Issue 1096803002: Fix check for return of error before calling SyncDirectoryListing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1096803002: Fix check for return of error before calling SyncDirectoryListing. (Closed)

Created:
5 years, 8 months ago by siva

Modified:
5 years, 8 months ago

Reviewers:
Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix check for return of error before calling SyncDirectoryListing. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45292

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/bin/directory.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Ivan Posva

LGTM, but we need to follow up on all of the other places where something ...

5 years, 8 months ago (2015-04-17 20:03:42 UTC) #4

siva

Yes, need to load another CL with all errors being checked, submitting this to fix ...

5 years, 8 months ago (2015-04-20 17:13:06 UTC) #5

siva

5 years, 8 months ago (2015-04-20 17:23:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r45292 (presubmit successful).