Issue 10968006: html.status updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10968006: html.status updated (Closed)

Created:
8 years, 3 months ago by Johnni Winther

Modified:
8 years, 3 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

html.status updated Committed: https://code.google.com/p/dart/source/detail?r=12625

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

On 2012/09/20 08:32:50, ngeoffray wrote: > Why is it not showing up in the buildbots? ...

8 years, 3 months ago (2012-09-20 08:48:53 UTC) #3

ngeoffray

On 2012/09/20 08:48:53, Johnni Winther wrote: > On 2012/09/20 08:32:50, ngeoffray wrote: > > Why ...

8 years, 3 months ago (2012-09-20 08:53:42 UTC) #4

ahe

8 years, 3 months ago (2012-09-20 09:10:51 UTC) #5

LGTM

Background:

Yes, we are not testing DRT on Windows, only Chrome. I'm not 100% sure why, but
I recall something about some instability issues.

Also, it is really Chrome that is the first priority to test. DRT is based on
Dartium and may behave differently than the "official" Chrome build. Said
another way, it matters more to our users that we generate JavaScript code that
works in Chrome than Dartium.

Expand Messages | Collapse Messages