Issue 10967069: Update dart2dart expectations after co19 roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10967069: Update dart2dart expectations after co19 roll. (Closed)

Created:
8 years, 2 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
ahe, Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update dart2dart expectations after co19 roll. TBR=ahe@google.com,smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=12781

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tests/co19/co19-dart2dart.status	View		3 chunks	+3 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/10967069/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/10967069/diff/1/tests/co19/co19-dart2dart.status#newcode56 tests/co19/co19-dart2dart.status:56: Language/09_Generics/09_Generics_A05_t01: Pass Why a pass?

8 years, 2 months ago (2012-09-24 15:03:05 UTC) #2

Anton Muhin

8 years, 2 months ago (2012-09-24 15:07:09 UTC) #3

https://codereview.chromium.org/10967069/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/10967069/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:56: Language/09_Generics/09_Generics_A05_t01:
Pass
On 2012/09/24 15:03:05, ahe wrote:
> Why a pass?

That's the cleanup I have to do.

Unfortunately, VM expectations are all behind [ $runtime == vm ], therefore all
their expectations apply to dart2dart as it's  $compiler == dart2dart &&
$runtime == vm.

To some extent it's even beneficial---we get tests failing on VM for free.  But
some cases, esp. for negative tests we should force Pass in this file.

I am going to start to cleanup this mess soon.

Expand Messages | Collapse Messages