Issue 10967041: Improve ShouldSpecializeForDouble to handle ICs with multiple checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10967041: Improve ShouldSpecializeForDouble to handle ICs with multiple checks. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve ShouldSpecializeForDouble to handle ICs with multiple checks. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12703

Patch Set 1 #

Total comments: 1

Patch Set 2 : use helpers #

Patch Set 3 : use helpers #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -15 lines)			Patch
		runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+9 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years, 3 months ago (2012-09-21 13:23:07 UTC) #2

lgtm

https://codereview.chromium.org/10967041/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/10967041/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:280: const bool seen_double =
It would be nice to have a helper that checks for at the combinations of
smi/double with least one double.

Expand Messages | Collapse Messages