Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 10967028: Adding constructor to ContentElement. (Closed)

Created:
8 years, 3 months ago by blois
Modified:
8 years, 2 months ago
Reviewers:
vsm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding constructor to ContentElement. BUG=3870 Committed: https://code.google.com/p/dart/source/detail?r=12851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/html/contentelement_test.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M tests/html/html.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vsm
lgtm If you createElement('content') in JS, what do you get in IE or FF? Does ...
8 years, 3 months ago (2012-09-24 22:21:19 UTC) #1
blois
8 years, 3 months ago (2012-09-24 22:24:06 UTC) #2
On 2012/09/24 22:21:19, vsm wrote:
> lgtm
> 
> If you createElement('content') in JS, what do you get in IE or FF?  Does it
> return an HTMLElement?

It creates an HTMLUnknownElement in both.

Powered by Google App Engine
This is Rietveld 408576698