Issue 10965044: Remove Webkit prefix for RequestAnimationFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10965044: Remove Webkit prefix for RequestAnimationFrame. (Closed)

Created:
8 years, 3 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove Webkit prefix for RequestAnimationFrame. Committed: https://code.google.com/p/dart/source/detail?r=12819

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -41 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		5 chunks	+6 lines, -17 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		4 chunks	+4 lines, -14 lines	0 comments	Download
M	lib/html/scripts/htmlrenamer.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/html/scripts/systemnative.py	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	lib/html/templates/html/dart2js/impl_Window.darttemplate	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lib/html/templates/html/interface/interface_Window.darttemplate	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/html/callbacks_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/10965044/diff/1/lib/html/scripts/htmlrenamer.py File lib/html/scripts/htmlrenamer.py (right): https://codereview.chromium.org/10965044/diff/1/lib/html/scripts/htmlrenamer.py#newcode110 lib/html/scripts/htmlrenamer.py:110: 'Window.webkitRequestAnimationFrame': 'requestAnimationFrame', Does this not cause duplicate definitions of ...

8 years, 3 months ago (2012-09-21 21:46:51 UTC) #2

Emily Fortuna

@blois: good point -- I had forgotten this complication when I made the change on ...

8 years, 2 months ago (2012-09-24 22:57:14 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 10965044: Remove Webkit prefix for RequestAnimationFrame. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages