Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 10965034: Implement Object.hashCode() (Closed)

Created:
8 years, 3 months ago by ahe
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Implement Object.hashCode() Committed: https://code.google.com/p/dart/source/detail?r=12704

Patch Set 1 #

Total comments: 6

Patch Set 2 : Handle native objects and test mangling. #

Patch Set 3 : Update dart2dart status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -25 lines) Patch
dart/lib/compiler/implementation/js_backend/native_emitter.dart View 1 2 chunks +12 lines, -0 lines 0 comments Download
dart/lib/compiler/implementation/lib/core_patch.dart View 1 1 chunk +2 lines, -8 lines 0 comments Download
dart/lib/compiler/implementation/lib/js_helper.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
dart/lib/compiler/implementation/lib/native_helper.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
dart/lib/compiler/implementation/native_handler.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
dart/tests/co19/co19-dart2dart.status View 1 2 2 chunks +1 line, -13 lines 0 comments Download
dart/tests/compiler/dart2js_native/hash_code_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
dart/tests/language/hash_code_mangling_test.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
dart/tests/language/language.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
dart/tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 3 months ago (2012-09-21 10:38:53 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart File dart/lib/compiler/implementation/lib/core_patch.dart (right): https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart#newcode16 dart/lib/compiler/implementation/lib/core_patch.dart:16: static int _hashCode = 0; Remove static. https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart#newcode21 ...
8 years, 3 months ago (2012-09-21 10:47:43 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart File dart/lib/compiler/implementation/lib/core_patch.dart (right): https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart#newcode23 dart/lib/compiler/implementation/lib/core_patch.dart:23: hash = ++_hashCode; It would be a good ...
8 years, 3 months ago (2012-09-21 10:47:49 UTC) #3
ahe
PTAL https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart File dart/lib/compiler/implementation/lib/core_patch.dart (right): https://codereview.chromium.org/10965034/diff/1/dart/lib/compiler/implementation/lib/core_patch.dart#newcode16 dart/lib/compiler/implementation/lib/core_patch.dart:16: static int _hashCode = 0; On 2012/09/21 10:47:43, ...
8 years, 3 months ago (2012-09-21 12:07:30 UTC) #4
ngeoffray
8 years, 3 months ago (2012-09-21 12:17:25 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698