Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10964030: A variety of cleanups to bring our samples up-to-date. (Closed)

Created:
8 years, 3 months ago by dgrove
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

A variety of cleanups to bring our samples up-to-date. Delete web components sample - there are new samples out on the web components github project. Committed: https://code.google.com/p/dart/source/detail?r=12671

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -546 lines) Patch
M samples/logo/logo.dart View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M samples/markdown/block_parser.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D samples/webcomponents/README View 1 chunk +0 lines, -10 lines 0 comments Download
D samples/webcomponents/contactifier/ContactsWidget.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D samples/webcomponents/contactifier/contactifier.css View 1 chunk +0 lines, -41 lines 0 comments Download
D samples/webcomponents/contactifier/contactifier.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/webcomponents/contactifier/contactifier.html View 1 chunk +0 lines, -28 lines 0 comments Download
D samples/webcomponents/list_map.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D samples/webcomponents/shadow_polyfill.dart View 1 chunk +0 lines, -347 lines 0 comments Download
M utils/css/tree.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M utils/template/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrove
8 years, 3 months ago (2012-09-21 00:04:35 UTC) #1
Siggi Cherem (dart-lang)
https://codereview.chromium.org/10964030/diff/4001/samples/markdown/block_parser.dart File samples/markdown/block_parser.dart (right): https://codereview.chromium.org/10964030/diff/4001/samples/markdown/block_parser.dart#newcode6 samples/markdown/block_parser.dart:6: final _RE_EMPTY = new RegExp(@'^([ \t]*)$'); why do we ...
8 years, 3 months ago (2012-09-21 00:17:27 UTC) #2
dgrove
https://codereview.chromium.org/10964030/diff/4001/samples/markdown/block_parser.dart File samples/markdown/block_parser.dart (right): https://codereview.chromium.org/10964030/diff/4001/samples/markdown/block_parser.dart#newcode6 samples/markdown/block_parser.dart:6: final _RE_EMPTY = new RegExp(@'^([ \t]*)$'); On 2012/09/21 00:17:28, ...
8 years, 3 months ago (2012-09-21 00:37:23 UTC) #3
Siggi Cherem (dart-lang)
8 years, 3 months ago (2012-09-21 00:38:42 UTC) #4 
lgtm!

Powered by Google App Engine
This is Rietveld 408576698