Issue 10964013: Add an internal flag to the dart2js compiler to enable/diable inlining

Issue 10964013: Add an internal flag to the dart2js compiler to enable/diable inlining (Closed)

Created:
8 years, 3 months ago by Søren Gjesse

Modified:
8 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add an internal flag to the dart2js compiler to enable/diable inlining Use this to run the type inference tests both with and wihtout inlining. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12757

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -4 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/call_site_type_inferer_static_test.dart	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/call_site_type_inferer_test.dart	View	1	3 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/10964013/diff/1/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/10964013/diff/1/lib/compiler/implementation/compiler.dart#newcode98 lib/compiler/implementation/compiler.dart:98: bool enableInlining = true; The way this is ...

8 years, 3 months ago (2012-09-21 15:00:27 UTC) #2

Søren Gjesse

8 years, 3 months ago (2012-09-24 07:32:26 UTC) #3

https://codereview.chromium.org/10964013/diff/1/lib/compiler/implementation/c...
File lib/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/10964013/diff/1/lib/compiler/implementation/c...
lib/compiler/implementation/compiler.dart:98: bool enableInlining = true;
On 2012/09/21 15:00:27, ahe wrote:
> The way this is used, it feels more like a "disableInlining" flag.

Done.

https://codereview.chromium.org/10964013/diff/1/tests/compiler/dart2js/call_s...
File tests/compiler/dart2js/call_site_type_inferer_static_test.dart (right):

https://codereview.chromium.org/10964013/diff/1/tests/compiler/dart2js/call_s...
tests/compiler/dart2js/call_site_type_inferer_static_test.dart:15: bool
enbaleInlining,
On 2012/09/21 15:00:27, ahe wrote:
> enbale -> enable.

Changed to disable here as well.

Expand Messages | Collapse Messages