Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 10964012: Revert "A simpler scheme for garbage collection of ureachable phi inputs." (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)
Modified:
8 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "A simpler scheme for garbage collection of ureachable phi inputs." This reverts svn revision 12621. It causes unexpected test timouts. TBR=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -111 lines) Patch
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 16 chunks +22 lines, -43 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 3 chunks +15 lines, -36 lines 0 comments Download
M runtime/vm/growable_array.h View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 9 chunks +34 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 3 chunks +49 lines, -14 lines 0 comments Download
M runtime/vm/intermediate_language_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
8 years, 3 months ago (2012-09-20 09:11:31 UTC) #1
Søren Gjesse
8 years, 3 months ago (2012-09-20 09:12:05 UTC) #2
Rubber stamp LGTM.

Powered by Google App Engine
This is Rietveld 408576698