Issue 10963022: Mark html/window_open_test flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10963022: Mark html/window_open_test flaky. (Closed)

Created:
8 years, 3 months ago by ricow1

Modified:
8 years, 3 months ago

Reviewers:
ahe, gram

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark html/window_open_test flaky. This is reappearing, see issue 5151 Committed: https://code.google.com/p/dart/source/detail?r=12681

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 3 months ago (2012-09-21 09:19:29 UTC) #3

Are you sure it is flaky?

I think Graham's change to the status file only made the test non-flaky. Fixing
the test requires this:

test('Enable opening of Windows', () {
 evaluateJavaScript('''
var tester = (testRunner || layoutTestController);
if (tester) tester.setCanOpenWindows()''');
});

Expand Messages | Collapse Messages