Issue 10962047: Issue 5327. Fix for invalid 'instantiation of a class with the inherited abstract members'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10962047: Issue 5327. Fix for invalid 'instantiation of a class with the inherited abstract members' (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5327. Fix for invalid 'instantiation of a class with the inherited abstract members' http://code.google.com/p/dart/issues/detail?id=5327 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12753

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -9 lines)			Patch
	M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		3 chunks	+20 lines, -8 lines	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View		2 chunks	+65 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 3 months ago (2012-09-22 16:19:59 UTC) #2

LGTM, with or without addressing my comment

https://codereview.chromium.org/10962047/diff/1/compiler/javatests/com/google...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://codereview.chromium.org/10962047/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:771:
"interface I {",
It might be good to re-write this now to use an abstract class so that we have
less work to do later to convert all of our tests.

Expand Messages | Collapse Messages