Issue 10962013: - Make the VM understand the --checked flag to be aligned with dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10962013: - Make the VM understand the --checked flag to be aligned with dart2js. (Closed)

Created:
8 years, 3 months ago by Ivan Posva

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Make the VM understand the --checked flag to be aligned with dart2js. - Adjust some of the checked mode tests to pass --checked and --enable-checked-mode. Committed: https://code.google.com/p/dart/source/detail?r=12651

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	runtime/vm/parser.cc	View	2 chunks	+7 lines, -2 lines	2 comments	Download
M	tests/language/factory3_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/generic_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/type_checks_in_factory_method_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/typed_message_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one typo to fix. https://chromiumcodereview.appspot.com/10962013/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/10962013/diff/1/runtime/vm/parser.cc#newcode48 runtime/vm/parser.cc:48: "Enabled checked mode."); ...

8 years, 3 months ago (2012-09-20 18:17:27 UTC) #2

Ivan Posva

8 years, 3 months ago (2012-09-20 18:18:44 UTC) #3

https://chromiumcodereview.appspot.com/10962013/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10962013/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:48: "Enabled checked mode.");
On 2012/09/20 18:17:27, regis wrote:
> Enabled -> Enable
> I fixed the same typo yesterday on line 44 and you reviewed it.

Done.

Expand Messages | Collapse Messages