Issue 10961074: Separate type for dynamic in mirrors.dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10961074: Separate type for dynamic in mirrors.dart2js (Closed)

Created:
8 years, 3 months ago by Johnni Winther

Modified:
8 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Separate type for dynamic in mirrors.dart2js Committed: https://code.google.com/p/dart/source/detail?r=12769

Patch Set 2 : Identity used on dynamic type #

Total comments: 2

Patch Set 3 : Updated cf. comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -48 lines)			Patch
	M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	1 2	11 chunks	+48 lines, -48 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

LGTM https://codereview.chromium.org/10961074/diff/2001/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/10961074/diff/2001/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode1238 pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1238: bool get isObject => false; Why not put ...

8 years, 3 months ago (2012-09-24 10:41:09 UTC) #2

Johnni Winther

8 years, 3 months ago (2012-09-24 10:58:18 UTC) #3

https://codereview.chromium.org/10961074/diff/2001/pkg/dartdoc/lib/src/mirror...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

https://codereview.chromium.org/10961074/diff/2001/pkg/dartdoc/lib/src/mirror...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1238: bool get isObject =>
false;
On 2012/09/24 10:41:09, Lasse Reichstein Nielsen wrote:
> Why not put these "false" getters on the supertype, and only override the true
> ones in subclasses? That seems like a quadratic->linear space optimization, if
> nothing else. (And it's easier to maintain - you only need to fix two places
> when adding a new one).

Done.