Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 10961038: Issue 5255. Remember 'overridden' for getters/setters and fields (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -4 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +7 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/FieldElement.java View 2 chunks +7 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java View 4 chunks +12 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/MethodElement.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 5 chunks +49 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 3 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-21 02:53:37 UTC) #1
Brian Wilkerson
8 years, 3 months ago (2012-09-21 14:12:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698