[dart2js] if --output-type=dart make output file out.dart and print correct info message.

[dart2js] if --output-type=dart make output file out.dart and print correct info message.

Committed: https://code.google.com/p/dart/source/detail?r=12758

[Anton Muhin, 2012-09-20 18:31:44]

lgtm, but, please, wait for sign off from Peter

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart2js.dart:268: String outputLang =
isOutputTypeDart ? 'Dart' : 'Javascript';
nit: Java<S>cript

[ahe, 2012-09-21 14:38:46]

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart2js.dart:102: out = cwd.resolve('out.dart');
This isn't right. You will overwrite user-specified output file in this case:

dart2js --out=minified_foo.dart --output-type=dart foo.dart

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart2js.dart:268: String outputLang =
isOutputTypeDart ? 'Dart' : 'Javascript';
Please don't abbreviate, that is, use "language" instead of "lang".

How about setting this variable earlier so setOutputType takes care of it?

[Roman, 2012-09-21 16:36:07]

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart2js.dart:102: out = cwd.resolve('out.dart');
On 2012/09/21 14:38:46, ahe wrote:
> This isn't right. You will overwrite user-specified output file in this case:
> 
> dart2js --out=minified_foo.dart --output-type=dart foo.dart

added a check for explicitOut set.

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart2js.dart:268: String outputLang =
isOutputTypeDart ? 'Dart' : 'Javascript';
On 2012/09/20 18:31:44, Anton Muhin wrote:
> nit: Java<S>cript

Done.

https://codereview.chromium.org/10961019/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart2js.dart:268: String outputLang =
isOutputTypeDart ? 'Dart' : 'Javascript';
On 2012/09/21 14:38:46, ahe wrote:
> Please don't abbreviate, that is, use "language" instead of "lang".
> 
> How about setting this variable earlier so setOutputType takes care of it?

Done.

[ahe, 2012-09-24 06:51:07]

LGTM!