Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issue 10961013: Add minimal documentation to the num class. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add minimal documentation to the num class. I have kept the documentation to a minimum and only added a few details. We can beef this up later if desirable. R=lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12635

Patch Set 1 #

Patch Set 2 : Use consistent comment style #

Patch Set 3 : minor tweak #

Total comments: 11

Patch Set 4 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -6 lines) Patch
M lib/core/num.dart View 1 2 3 1 chunk +70 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 3 months ago (2012-09-20 10:56:01 UTC) #1
Lasse Reichstein Nielsen
LGTM https://codereview.chromium.org/10961013/diff/4001/lib/core/num.dart File lib/core/num.dart (right): https://codereview.chromium.org/10961013/diff/4001/lib/core/num.dart#newcode8 lib/core/num.dart:8: /// Addition operator. Why the /// comments now? ...
8 years, 3 months ago (2012-09-20 12:49:38 UTC) #2
Mads Ager (google)
https://codereview.chromium.org/10961013/diff/4001/lib/core/num.dart File lib/core/num.dart (right): https://codereview.chromium.org/10961013/diff/4001/lib/core/num.dart#newcode8 lib/core/num.dart:8: /// Addition operator. On 2012/09/20 12:49:38, Lasse Reichstein Nielsen ...
8 years, 3 months ago (2012-09-20 13:36:08 UTC) #3
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-20 19:45:13 UTC) #4
https://codereview.chromium.org/10961013/diff/4001/lib/core/num.dart
File lib/core/num.dart (right):

https://codereview.chromium.org/10961013/diff/4001/lib/core/num.dart#newcode38
lib/core/num.dart:38: /// isNan predicate.
They increase the information (not by a lot, but still) by giving names to the
operators. Saying "addition" is more meaningful than "plus" - the former is an
arithmetic operation, the latter is just the symbol.
So keep them.

Powered by Google App Engine
This is Rietveld 408576698