Issue 10960062: Fix SendPortSync dispatch for FF

Issue 10960062: Fix SendPortSync dispatch for FF (Closed)

Created:
8 years, 3 months ago by vsm

Modified:
8 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix SendPortSync dispatch for FF TextEvent (used previously) does not work on FireFox Committed: https://code.google.com/p/dart/source/detail?r=12857

Patch Set 2 : Cleanup for dartium #

Total comments: 6

Patch Set 3 : Fix indentation #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -25 lines)			Patch
M	client/dart.js	View	1 2	3 chunks	+8 lines, -4 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/html/src/Isolates.dart	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	lib/html/templates/html/dartium/html_dartium.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/html.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://chromiumcodereview.appspot.com/10960062/diff/2001/client/dart.js File client/dart.js (right): https://chromiumcodereview.appspot.com/10960062/diff/2001/client/dart.js#newcode224 client/dart.js:224: event.initCustomEvent(receiver, false, false, string); odd indenting. https://chromiumcodereview.appspot.com/10960062/diff/2001/lib/html/src/Isolates.dart File ...

8 years, 3 months ago (2012-09-24 22:20:14 UTC) #2

vsm

8 years, 2 months ago (2012-09-25 16:22:51 UTC) #3

Thanks, landing.

https://codereview.chromium.org/10960062/diff/2001/client/dart.js
File client/dart.js (right):

https://codereview.chromium.org/10960062/diff/2001/client/dart.js#newcode224
client/dart.js:224: event.initCustomEvent(receiver, false, false, string);
On 2012/09/24 22:20:14, blois wrote:
> odd indenting.

Done.

https://codereview.chromium.org/10960062/diff/2001/lib/html/src/Isolates.dart
File lib/html/src/Isolates.dart (right):

https://codereview.chromium.org/10960062/diff/2001/lib/html/src/Isolates.dart...
lib/html/src/Isolates.dart:92: var listener = (Event e) {
On 2012/09/24 22:20:14, blois wrote:
> Seems like this should be CustomEvent, no? detail field isn't on Event.

I've had the change the Event type a couple times, so I wanted to abstract out
what type of Event it is.  _getPortSyncEventData has the more specific type on
it.

https://codereview.chromium.org/10960062/diff/2001/lib/html/src/Isolates.dart...
lib/html/src/Isolates.dart:164: _listener = (Event e) {
See above.

On 2012/09/24 22:20:14, blois wrote:
> CustomEvent?

Expand Messages | Collapse Messages