Issue 10960011: Made removeAt errors consistent between dart2js and VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10960011: Made removeAt errors consistent between dart2js and VM. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Made removeAt errors consistent between dart2js and VM. Reneabled test for VM. Committed: https://code.google.com/p/dart/source/detail?r=12632

Patch Set 2 : Address comment. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -14 lines)			Patch
M	lib/compiler/implementation/lib/interceptors.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/core/list.dart	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/list_removeat_test.dart	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/10960011/diff/1/runtime/lib/growable_array.dart File runtime/lib/growable_array.dart (right): https://codereview.chromium.org/10960011/diff/1/runtime/lib/growable_array.dart#newcode14 runtime/lib/growable_array.dart:14: Arrays.copy(this, Cache this.length in a local variable?

8 years, 3 months ago (2012-09-20 12:42:41 UTC) #2

Lasse Reichstein Nielsen

8 years, 3 months ago (2012-09-20 12:52:30 UTC) #3

https://codereview.chromium.org/10960011/diff/1/runtime/lib/growable_array.dart
File runtime/lib/growable_array.dart (right):

https://codereview.chromium.org/10960011/diff/1/runtime/lib/growable_array.da...
runtime/lib/growable_array.dart:14: Arrays.copy(this,
Better yet, I'll cache this.length - 1.

Expand Messages | Collapse Messages

Issue 10960011: Made removeAt errors consistent between dart2js and VM. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages