Issue 10959074: Make PASS, FAIL, ERROR public (see issue 5365).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10959074: Make PASS, FAIL, ERROR public (see issue 5365). (Closed)

Created:
8 years, 3 months ago by gram

Modified:
8 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make PASS, FAIL, ERROR public (see issue 5365). Committed: https://code.google.com/p/dart/source/detail?r=12798

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	pkg/unittest/test_case.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
	M	pkg/unittest/unittest.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 3 months ago (2012-09-24 18:38:21 UTC) #2

lgtm

Could you add a TODO about the following: we should change these constants to
use a different string (so that writing 'FAIL' in the middle of a test doesn't
imply that the test fails). We can't do it without fixing also the testrunner
and test.dart though.

Expand Messages | Collapse Messages