Deal with deferred loading in the VM mirrors.

Deal with deferred loading in the VM mirrors.

- Invalidate MirrorSystem.libraries when a load completes.
- Recheck if a deferred import's target has been loaded before failing.
- Allow loading libraries from a LibraryDepedencyMirror.
- Propogate compile-time error when attempting to reflect a deferred type.

BUG=http://dartbug.com/22592
R=asiva@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45444

[rmacnak, 2015-04-18 00:50:57]

rmacnak@google.com changed reviewers:
+ asiva@google.com, gbracha@google.com

[gbracha, 2015-04-18 18:00:46]

Minor comments and questions.

https://codereview.chromium.org/1095903002/diff/20001/pkg/compiler/lib/src/mi...
File pkg/compiler/lib/src/mirrors/source_mirrors.dart (right):

https://codereview.chromium.org/1095903002/diff/20001/pkg/compiler/lib/src/mi...
pkg/compiler/lib/src/mirrors/source_mirrors.dart:146: /*Future<LibraryMirror>*/
loadLibrary();
shouldn't there be a comment on this?

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
File tests/lib/mirrors/library_enumeration_deferred_loading_test.dart (right):

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_enumeration_deferred_loading_test.dart:5: library
libray_enumeration_deferred_loading;
libray -> library

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_enumeration_deferred_loading_test.dart:23: }
This is not exactly parallel to the other two (import and load_library) tests.

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
File tests/lib/mirrors/library_import_deferred_loading_test.dart (right):

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_import_deferred_loading_test.dart:5: library
libray_loading_deferred_loading;
libray -> library (this isn't deliberate is it?)

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_import_deferred_loading_test.dart:25:
Expect.equals(#test.other_library, dep.targetLibrary.simpleName);
So the load_library version also calls a method. Why is it not exactly parallel
to this test?

[rmacnak, 2015-04-20 17:21:04]

https://codereview.chromium.org/1095903002/diff/20001/pkg/compiler/lib/src/mi...
File pkg/compiler/lib/src/mirrors/source_mirrors.dart (right):

https://codereview.chromium.org/1095903002/diff/20001/pkg/compiler/lib/src/mi...
pkg/compiler/lib/src/mirrors/source_mirrors.dart:146: /*Future<LibraryMirror>*/
loadLibrary();
On 2015/04/18 18:00:46, gbracha wrote:
> shouldn't there be a comment on this?

Done.

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
File tests/lib/mirrors/library_enumeration_deferred_loading_test.dart (right):

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_enumeration_deferred_loading_test.dart:5: library
libray_enumeration_deferred_loading;
On 2015/04/18 18:00:46, gbracha wrote:
> libray -> library

Done.

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_enumeration_deferred_loading_test.dart:23: }
On 2015/04/18 18:00:46, gbracha wrote:
> This is not exactly parallel to the other two (import and load_library) tests.

Filled in gap.

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
File tests/lib/mirrors/library_import_deferred_loading_test.dart (right):

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_import_deferred_loading_test.dart:5: library
libray_loading_deferred_loading;
On 2015/04/18 18:00:46, gbracha wrote:
> libray -> library (this isn't deliberate is it?)

Done.

https://codereview.chromium.org/1095903002/diff/20001/tests/lib/mirrors/libra...
tests/lib/mirrors/library_import_deferred_loading_test.dart:25:
Expect.equals(#test.other_library, dep.targetLibrary.simpleName);
On 2015/04/18 18:00:46, gbracha wrote:
> So the load_library version also calls a method. Why is it not exactly
parallel
> to this test?

Added

[gbracha, 2015-04-20 20:34:36]

tests, API lgtm

[siva, 2015-04-22 17:28:00]

LGTM with one comment regarding the API

https://codereview.chromium.org/1095903002/diff/40001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/1095903002/diff/40001/runtime/lib/mirrors.cc#...
runtime/lib/mirrors.cc:24: } })                                                 
                   \
why is the formatting done this way instead of just plain
#define PROP....             \
if (type.IsMalformed()) {    \
  ...                        \
}

https://codereview.chromium.org/1095903002/diff/40001/sdk/lib/mirrors/mirrors...
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/1095903002/diff/40001/sdk/lib/mirrors/mirrors...
sdk/lib/mirrors/mirrors.dart:77: Map<Uri, LibraryMirror> get libraries;
There is a subtle difference here now, the documentation states 'all libraries
known to the mirror system' but now the implementation only returns a list of
libraries that are loaded.
I am wondering if the API needs to change to allow people to query and get both
lists
- list of libraries known to the mirror system
- list of libraries loaded

[rmacnak, 2015-04-22 18:05:44]

https://codereview.chromium.org/1095903002/diff/40001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/1095903002/diff/40001/runtime/lib/mirrors.cc#...
runtime/lib/mirrors.cc:24: } })                                                 
                   \
On 2015/04/22 17:28:00, siva wrote:
> why is the formatting done this way instead of just plain
> #define PROP....             \
> if (type.IsMalformed()) {    \
>   ...                        \
> }

I copied from a macro that was using its return value. Simplified.

https://codereview.chromium.org/1095903002/diff/40001/sdk/lib/mirrors/mirrors...
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/1095903002/diff/40001/sdk/lib/mirrors/mirrors...
sdk/lib/mirrors/mirrors.dart:77: Map<Uri, LibraryMirror> get libraries;
On 2015/04/22 17:28:00, siva wrote:
> There is a subtle difference here now, the documentation states 'all libraries
> known to the mirror system' but now the implementation only returns a list of
> libraries that are loaded.
> I am wondering if the API needs to change to allow people to query and get
both
> lists
> - list of libraries known to the mirror system
> - list of libraries loaded

I think some of the vagueness here is to allow for source mirror systems, whose
known libraries would depend on what source the mirror system was constructed
with. Gilad, PTAL at the clarification I added that runtime mirror systems only
include loaded libraries.

[rmacnak, 2015-04-28 23:48:00]

Committed patchset #5 (id:80001) manually as 45444 (presubmit successful).