Issue 10958069: Variable use should not be mapped to its declaration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10958069: Variable use should not be mapped to its declaration. (Closed)

Created:
8 years, 3 months ago by podivilov

Modified:
8 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Variable use should not be mapped to its declaration. R=floitsch@google.com BUG=5331 Committed: https://code.google.com/p/dart/source/detail?r=12837

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

Looks like we need to mess with generated JavaScript in source map tests to catch ...

8 years, 3 months ago (2012-09-24 15:16:47 UTC) #2

floitsch

8 years, 3 months ago (2012-09-24 15:47:34 UTC) #3

LGTM.
wrt testing: not sure yet. Maybe we should have some very simple dart functions
and make sure that they are identical to what we would expect. Then we would
have caught this bug.
It might also be a good idea to verify by hand when output-locations are not in
sequence.
But this is for another CL.

Expand Messages | Collapse Messages