Issue 10958027: Disable problematic http test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10958027: Disable problematic http test (Closed)

Created:
8 years, 3 months ago by Alan Knight

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disable problematic http test Committed: https://code.google.com/p/dart/source/detail?r=12675

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	pkg/pkg.status	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years, 3 months ago (2012-09-21 01:00:43 UTC) #2

LGTM

https://codereview.chromium.org/10958027/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/10958027/diff/1/pkg/pkg.status#newcode33
pkg/pkg.status:33: # Skip http request tests on Dartium, because we can't skip
it on incremental builds
Can you fix the long lines while you're in here?

Expand Messages | Collapse Messages