Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 10957061: Do not use wildcards in expectations. (Closed)

Created:
8 years, 3 months ago by Anton Muhin
Modified:
8 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not use wildcards in expectations. R=ahe@google.com BUG=5401 Committed: https://code.google.com/p/dart/source/detail?r=12838

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M tests/co19/co19-dart2dart.status View 1 2 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 3 months ago (2012-09-24 14:13:04 UTC) #1
Anton Muhin
https://codereview.chromium.org/10957061/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/10957061/diff/1/tests/co19/co19-dart2dart.status#newcode55 tests/co19/co19-dart2dart.status:55: Language/08_Interfaces: Skip # ~30 failures, interfaces are going away, ...
8 years, 3 months ago (2012-09-24 14:13:58 UTC) #2
ahe
https://codereview.chromium.org/10957061/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/10957061/diff/1/tests/co19/co19-dart2dart.status#newcode55 tests/co19/co19-dart2dart.status:55: Language/08_Interfaces: Skip # ~30 failures, interfaces are going away, ...
8 years, 3 months ago (2012-09-24 14:59:16 UTC) #3
Anton Muhin
PTL
8 years, 2 months ago (2012-09-25 09:49:47 UTC) #4
ahe
8 years, 2 months ago (2012-09-25 11:07:44 UTC) #5
LGTM, thank you!

Powered by Google App Engine
This is Rietveld 408576698