Issue 10957040: Allow static fields without types (issue 5149)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10957040: Allow static fields without types (issue 5149) (Closed)

Created:
8 years, 3 months ago by Brian Wilkerson

Modified:
8 years, 3 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow static fields without types (issue 5149) Committed: https://code.google.com/p/dart/source/detail?r=12720

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -17 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	5 chunks	+83 lines, -11 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM http://codereview.chromium.org/10957040/diff/1/tests/co19/co19-compiler.status File tests/co19/co19-compiler.status (right): http://codereview.chromium.org/10957040/diff/1/tests/co19/co19-compiler.status#newcode72 tests/co19/co19-compiler.status:72: Language/07_Classes/07_Classes_A02_t01: Fail # invalid test Do you open ...

8 years, 3 months ago (2012-09-21 16:10:18 UTC) #2

Brian Wilkerson

8 years, 3 months ago (2012-09-21 16:14:18 UTC) #3

http://codereview.chromium.org/10957040/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (right):

http://codereview.chromium.org/10957040/diff/1/tests/co19/co19-compiler.statu...
tests/co19/co19-compiler.status:72: Language/07_Classes/07_Classes_A02_t01: Fail
# invalid test
> Do you open co19 issue?

No, you did.

> Would be good to have its ID here.

Done.

Expand Messages | Collapse Messages