- Add definition of "int hashCode()" to Object.

- Add definition of "int hashCode()" to Object.
- Implement hashCode in the VM.
- Mark hashCode as unimplemented in dart2js.
- Update test using the identity hashcode.
Committed: https://code.google.com/p/dart/source/detail?r=12669

[Ivan Posva, 2012-09-20 22:17:30]

This fixes the VM bug 5267 and provides a framework to implement dart2js bug
5268.

-Ivan

[siva, 2012-09-21 00:16:38]

lgtm

[ahe, 2012-09-21 09:15:56]

Except for the unreachable code, dart2js changes look good to me!

https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/core_patch.dart (right):

https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/core_patch.dart:21: return -1;
This is unreachable code. This will lead to a warning that is confused about the
location due to poor testing of the patch mechanism in dart2js:

lib/core/object.dart:25:55: Warning: unreachable code
 * Check whether two references are to the same object.
                                                      ^^

Johnni is working on fixing the patch diagnostic issues.

[Ivan Posva, 2012-09-24 17:16:47]

https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/core_patch.dart (right):

https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/core_patch.dart:21: return -1;
On 2012/09/21 09:15:57, ahe wrote:
> This is unreachable code. This will lead to a warning that is confused about
the
> location due to poor testing of the patch mechanism in dart2js:
> 
> lib/core/object.dart:25:55: Warning: unreachable code
>  * Check whether two references are to the same object.
>                                                       ^^
> 
> Johnni is working on fixing the patch diagnostic issues.

Thanks for the feedback. Next time I will not attempt to alert dart2js'
implementation as missing and instead just make it always return some constant.

[ahe, 2012-09-24 17:19:11]

https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/core_patch.dart (right):

https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/core_patch.dart:21: return -1;
On 2012/09/24 17:16:47, Ivan Posva wrote:
> Thanks for the feedback. Next time I will not attempt to alert dart2js'
> implementation as missing and instead just make it always return some
constant.

Or you can just use "throw", there no need to have a "return" after "throw".

[Ivan Posva, 2012-09-24 17:27:06]

On 2012/09/24 17:19:11, ahe wrote:
>
https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
> File lib/compiler/implementation/lib/core_patch.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10956026/diff/1/lib/compiler/implement...
> lib/compiler/implementation/lib/core_patch.dart:21: return -1;
> On 2012/09/24 17:16:47, Ivan Posva wrote:
> > Thanks for the feedback. Next time I will not attempt to alert dart2js'
> > implementation as missing and instead just make it always return some
> constant.
> 
> Or you can just use "throw", there no need to have a "return" after "throw".

Thanks! I did not know that. But it makes perfect sense.

-Ivan