Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 10952017: It seems Chrome on MacOS doesn't support testrunner or layoutTestController either, so marking the … (Closed)

Created:
8 years, 3 months ago by gram
Modified:
8 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

It seems Chrome on MacOS doesn't support testrunner or layoutTestController either, so marking the test as fail for macos. Committed: https://code.google.com/p/dart/source/detail?r=12525

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/html/html.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gram
8 years, 3 months ago (2012-09-19 00:10:52 UTC) #1
Emily Fortuna
https://chromiumcodereview.appspot.com/10952017/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10952017/diff/1/tests/html/html.status#newcode204 tests/html/html.status:204: [ $system == macos ] can you make this: ...
8 years, 3 months ago (2012-09-19 00:25:09 UTC) #2
gram
PTAL
8 years, 3 months ago (2012-09-19 00:31:39 UTC) #3
Emily Fortuna
8 years, 3 months ago (2012-09-19 00:34:59 UTC) #4
lgtm! :-)

Powered by Google App Engine
This is Rietveld 408576698