Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1095143002: Initial version of completion plugin API (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initial version of completion plugin API R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=45293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -15 lines) Patch
A pkg/analysis_server/lib/completion/completion_core.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/completion/completion_dart.dart View 1 chunk +57 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 8 chunks +55 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
This doesn't update the existing completion framework to match, but does provide a starting point.
5 years, 8 months ago (2015-04-20 17:32:55 UTC) #2
danrubel
lgtm
5 years, 8 months ago (2015-04-20 17:43:49 UTC) #3
Brian Wilkerson
5 years, 8 months ago (2015-04-20 17:44:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698