Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1095113004: include importUri in out of scope suggestions (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

include importUri in out of scope suggestions BUG=dartbug.com/23175 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45349

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -75 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 5 chunks +10 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +33 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 18 chunks +58 lines, -43 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 3 chunks +58 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-20 22:21:22 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-20 23:28:49 UTC) #3
danrubel
5 years, 8 months ago (2015-04-22 14:31:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698