Fix algorithm to know whether we should emit an is check on a class: all interfaces/implemented cla…

Fix algorithm to know whether we should emit an is check on a class: all interfaces/implemented classes must look at their extends clause.
Committed: https://code.google.com/p/dart/source/detail?r=12548

[Lasse Reichstein Nielsen, 2012-09-19 09:52:10]

LGTM.

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:699: void
generateTypeTests(ClassElement cls,
Is this generating type-test support on cls, or for testing against cls?

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:706:
generateInterfacesIsTests(
Why is it called "IsTests" in the called function's name, but "TypeTests" in
this function's name? Is it the same thing?

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:711: void
generateInterfacesIsTests(ClassElement cls,
Please document what the function does.
And the function above too.
I can't see if what is does is correct without knowing what it should do, and
the name is not sufficient here.

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:727: // We need to also emit
Fix linebreaking. Put quotes around "is-checks" or something similar to make it
stand out from the normal words.

https://codereview.chromium.org/10951026/diff/1/tests/language/is_interfaces2...
File tests/language/is_interfaces2_test.dart (right):

https://codereview.chromium.org/10951026/diff/1/tests/language/is_interfaces2...
tests/language/is_interfaces2_test.dart:17: int inscrutable(int x) => x == 0 ? 0
: x | inscrutable(x & (x - 1));
Please add parentheses!

[ngeoffray, 2012-09-19 10:14:39]

Thanks Lasse.

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:699: void
generateTypeTests(ClassElement cls,
On 2012/09/19 09:52:10, Lasse Reichstein Nielsen wrote:
> Is this generating type-test support on cls, or for testing against cls?

Type-test support. I changed the method name.

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:706:
generateInterfacesIsTests(
On 2012/09/19 09:52:10, Lasse Reichstein Nielsen wrote:
> Why is it called "IsTests" in the called function's name, but "TypeTests" in
> this function's name? Is it the same thing?

Renamed everything to IsTest instead of TypeTest.

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:711: void
generateInterfacesIsTests(ClassElement cls,
On 2012/09/19 09:52:10, Lasse Reichstein Nielsen wrote:
> Please document what the function does.
> And the function above too.
> I can't see if what is does is correct without knowing what it should do, and
> the name is not sufficient here.

Done.

https://codereview.chromium.org/10951026/diff/1/lib/compiler/implementation/j...
lib/compiler/implementation/js_backend/emitter.dart:727: // We need to also emit
On 2012/09/19 09:52:10, Lasse Reichstein Nielsen wrote:
> Fix linebreaking. Put quotes around "is-checks" or something similar to make
it
> stand out from the normal words.

Done.

https://codereview.chromium.org/10951026/diff/1/tests/language/is_interfaces2...
File tests/language/is_interfaces2_test.dart (right):

https://codereview.chromium.org/10951026/diff/1/tests/language/is_interfaces2...
tests/language/is_interfaces2_test.dart:17: int inscrutable(int x) => x == 0 ? 0
: x | inscrutable(x & (x - 1));
On 2012/09/19 09:52:10, Lasse Reichstein Nielsen wrote:
> Please add parentheses!

But you should not scrutinize it! :) Done