Use ExtensionManager and EnginePlugin to configure task list.

Use ExtensionManager and EnginePlugin to configure task list.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=45290

[scheglov, 2015-04-19 01:35:40]

On 2015/04/19 01:30:31, scheglov wrote:

And I still need to update the version and publish.
The currently published version of the analyzer package does not have all the
needed tasks.

[Brian Wilkerson, 2015-04-19 17:35:48]

LGTM

https://codereview.chromium.org/1095013002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1095013002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/dart_test.dart:1867:
taskDescriptors.forEach(taskManager.addTaskDescriptor);
or

EnginePlugin plugin = new EnginePlugin();
extensionManager.processPlugins([plugin]);
taskManager.addTaskDescriptors(plugin.taskDescriptors())

[scheglov, 2015-04-19 20:15:22]

https://codereview.chromium.org/1095013002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1095013002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/dart_test.dart:1867:
taskDescriptors.forEach(taskManager.addTaskDescriptor);
On 2015/04/19 17:35:48, Brian Wilkerson wrote:
> or
> 
> EnginePlugin plugin = new EnginePlugin();
> extensionManager.processPlugins([plugin]);
> taskManager.addTaskDescriptors(plugin.taskDescriptors())

I don't see addTaskDescriptors() method in TaskManager.
Is it coming?
Or do you recommend adding it?

Should plugin.taskDescriptors be a getter?

[Brian Wilkerson, 2015-04-19 20:21:15]

https://codereview.chromium.org/1095013002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1095013002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/dart_test.dart:1867:
taskDescriptors.forEach(taskManager.addTaskDescriptor);
> I don't see addTaskDescriptors() method in TaskManager.
> Is it coming?

Yes, sorry, I forgot that it wasn't committed yet.

> Should plugin.taskDescriptors be a getter?

I suppose it could be. As far as I can think it shouldn't ever be long running
or need an argument.

[scheglov, 2015-04-20 16:30:17]

Committed patchset #2 (id:20001) manually as 45290 (presubmit successful).