Issue 10950025: Dartdoc supports package directory.

Issue 10950025: Dartdoc supports package directory. (Closed)

Created:
8 years, 3 months ago by Johnni Winther

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Bob Nystrom, sethladd

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dartdoc supports package directory. BUG=4634, 5218 Committed: https://code.google.com/p/dart/source/detail?r=12623

Patch Set 2 : Updated cf. comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
M	pkg/dartdoc/bin/dartdoc.dart	View	1	3 chunks	+13 lines, -2 lines	0 comments	Download
M	pkg/dartdoc/lib/dartdoc.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://chromiumcodereview.appspot.com/10950025/diff/1/pkg/dartdoc/bin/dartdoc.dart File pkg/dartdoc/bin/dartdoc.dart (right): https://chromiumcodereview.appspot.com/10950025/diff/1/pkg/dartdoc/bin/dartdoc.dart#newcode38 pkg/dartdoc/bin/dartdoc.dart:38: final libPath = scriptDir.append('../../../'); final what? I'm guessing ...

8 years, 3 months ago (2012-09-19 12:06:49 UTC) #2

Bob Nystrom

One FYI. https://chromiumcodereview.appspot.com/10950025/diff/1/pkg/dartdoc/bin/dartdoc.dart File pkg/dartdoc/bin/dartdoc.dart (right): https://chromiumcodereview.appspot.com/10950025/diff/1/pkg/dartdoc/bin/dartdoc.dart#newcode38 pkg/dartdoc/bin/dartdoc.dart:38: final libPath = scriptDir.append('../../../'); On 2012/09/19 12:06:49, ...

8 years, 3 months ago (2012-09-19 16:17:17 UTC) #3

Johnni Winther

8 years, 3 months ago (2012-09-20 08:55:59 UTC) #4

http://codereview.chromium.org/10950025/diff/1/pkg/dartdoc/bin/dartdoc.dart
File pkg/dartdoc/bin/dartdoc.dart (right):

http://codereview.chromium.org/10950025/diff/1/pkg/dartdoc/bin/dartdoc.dart#n...
pkg/dartdoc/bin/dartdoc.dart:159: dartdoc.dartdocPath =
libPath.append('pkg/dartdoc');
On 2012/09/19 12:06:49, Lasse Reichstein Nielsen wrote:
> bad indent?

Done.

http://codereview.chromium.org/10950025/diff/1/utils/apidoc/apidoc.dart
File utils/apidoc/apidoc.dart (right):

http://codereview.chromium.org/10950025/diff/1/utils/apidoc/apidoc.dart#newco...
utils/apidoc/apidoc.dart:94: libPath, pkgPath);
On 2012/09/19 12:06:49, Lasse Reichstein Nielsen wrote:
> Now you are passing two paths around together almost all the time. Would it
make
> sense to put them into a single configuration object?

The first is fixed by the system and the second can be provided by the user, so
unless we need a more general passing of arguments I will stick we the two
parallel arguments.

Expand Messages | Collapse Messages